[Bug 187317] Review Request: mindi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mindi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187317


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list at redhat.com             |review at redhat.com




------- Additional Comments From bruno.cornec at hp.com  2006-04-20 04:49 EST -------
First I generate multiple RPMs for various distro from a single spec template +
m4 macros.
then I used rpmlint to check for potential issues before submiting and solved
nearly all of them.

* The tags at the begining not needed, but result from that generation process,
and I don't think it's a big issue in itself.
* %__id_u is not available for all distro, so I replaced it with id -u -n
* Group modified
* The path used in the scriptlet is just a check to avoid simultaneous
installation of the tool from the tar ball and the rpm which leaded to issuse in
the past. So it has to echo something, if not iy's useless. I can't adapt the
path, as this path is precisely unrelated to the ones used in the package.
* I modified thr Source: tag to include full path
* I removed the cleanup in %prep
* There is no build phase in itself, as mindi is based on script, and
configuration files, as well as a small chroot content. So I don't see your
point because I don't build in the install phase. I really just install wit the
install.sh script.
* I added /etc/mindi as a %config in %files
* The problem of the duplicate files is due to te fact that the defattr is 644,
but I need that some files be 755. Doing it in install (I went there) does not
solve that issue, as rpm behind rechange the modes, if you don't put them with
attr later on. Any solution to that issue ?
* Changelog added (forgot it)

New version available at
ftp://ftp.mondorescue.org/fedora/5/mindi-1.0.7-495.fc5.src.rpm






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.