[Bug 189482] Review Request: pcb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189482


Jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |Jochen at herr-schmitt.de
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From Jochen at herr-schmitt.de  2006-04-20 11:22 EST -------
Good:

+ Local build worked fine.

Bad:
- source0 doesn't contains a fulled qualified URL.
- BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- No menu entry for GUIs exists
- Mock build fails with:

checking for cygwish83... no
checking for cygwish80... no
configure: error: Did not find the wish executible.  You need to make sure
        that tcl is installed on your system and that wish is in your path
error: Bad exit status from /var/tmp/rpm-tmp.14070 (%build)


I asume, that tcl should be a BuildRequires.

- rpmlint on source rpm complaints:
W: pcb summary-ended-with-dot An interactive printed circuit board editor.
W: pcb strange-permission pcb.spec 0600

- rpmlint on binary rpm complaints:
W: pcb summary-ended-with-dot An interactive printed circuit board editor.
E: pcb info-files-without-install-info-postin /usr/share/info/pcb.info.gz
E: pcb info-files-without-install-info-postun /usr/share/info/pcb.info.gz
E: pcb non-executable-script /usr/share/pcb/tools/PCB2HPGL 0644
W: pcb devel-file-in-non-devel-package /usr/share/pcb/tools/gerbertotk.c
E: pcb info-files-without-install-info-postin /usr/share/info/pcb.info-2.gz
E: pcb info-files-without-install-info-postun /usr/share/info/pcb.info-2.gz
E: pcb standard-dir-owned-by-package /usr/share/man/man1
E: pcb non-executable-script /usr/share/pcb/tools/Merge_dimPCBPS 0644
E: pcb non-executable-script /usr/share/pcb/tools/tgo2pcb.tcl 0644
E: pcb info-files-without-install-info-postin /usr/share/info/pcb.info-1.gz
E: pcb info-files-without-install-info-postun /usr/share/info/pcb.info-1.gz
E: pcb non-executable-script /usr/share/pcb/tools/MergePCBPS 0644

- Package doesn't contains a verbatin written copy of the license text.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.