[Bug 180149] Review Request: edje: A complex graphical design and layout library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: edje: A complex graphical design and layout library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180149


Christian.Iseli at licr.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |Christian.Iseli at licr.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From Christian.Iseli at licr.org  2006-04-20 18:02 EST -------
Good:
- rpmlint is ok
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English and legible
- source matches upstream
- builds, installs, runs, and uninstalls cleanly
- BuildRequires ok
- no locale to worry about
- shared libs ok
- -devel package ok
- no relocation to worry about
- no duplicated files
- files perms ok
- clean section ok
- macro useage ok
- package contains code
- no large doc
- %doc is only doc
- builds in mock

My machines here still run FC4, so I didn't check if the code actualy runs...
but I'll trust you on this one.

Why the empty %doc in the devel package ?

I think %{_datadir}/%{name}/ is more explicit than %{_datadir}/%{name}
but that's a matter of taste I guess...

rpmlint says:
E: edje non-executable-script /usr/share/edje/data/template/build_theme.sh 0644
E: edje non-executable-script /usr/share/edje/data/e_logo.sh 0644

W: edje-devel no-documentation

which I think can be ignored.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.