[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-04-22 12:53 EST -------
I started on a review, but the package fails to build in mock:

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/valid....Can't locate Mail/Address.pm in @INC (@INC contains:
/builddir/build/BUILD/Email-Valid-0.15/blib/lib
/builddir/build/BUILD/Email-Valid-0.15/blib/arch
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.4/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl/5.8.7
/usr/lib/perl5/site_perl/5.8.6 /usr/lib/perl5/site_perl/5.8.5
/usr/lib/perl5/site_perl/5.8.4 /usr/lib/perl5/site_perl/5.8.3
/usr/lib/perl5/site_perl
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.4/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.3/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl/5.8.7
/usr/lib/perl5/vendor_perl/5.8.6 /usr/lib/perl5/vendor_perl/5.8.5
/usr/lib/perl5/vendor_perl/5.8.4 /usr/lib/perl5/vendor_perl/5.8.3
/usr/lib/perl5/vendor_perl /usr/lib/perl5/5.8.8/i386-linux-thread-multi
/usr/lib/perl5/5.8.8 .) at
/builddir/build/BUILD/Email-Valid-0.15/blib/lib/Email/Valid.pm line 9.
BEGIN failed--compilation aborted at
/builddir/build/BUILD/Email-Valid-0.15/blib/lib/Email/Valid.pm line 9.
Compilation failed in require at t/valid.t line 11.
BEGIN failed--compilation aborted at t/valid.t line 11.
dubious
        Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 1-12
        Failed 12/12 tests, 0.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/valid.t      2   512    12   23 191.67%  1-12
Failed 1/1 test scripts, 0.00% okay. 12/12 subtests failed, 0.00% okay.
make: *** [test_dynamic] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.55843 (%check)

I believe you're missing a BuildRequires: perl(Mail::Address), but after adding
it things fail again:

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/valid....unable to locate nslookup at t/valid.t line 46
dubious
        Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 9-12
        Failed 4/12 tests, 66.67% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/valid.t      2   512    12    8  66.67%  9-12
Failed 1/1 test scripts, 0.00% okay. 4/12 subtests failed, 66.67% okay.
make: *** [test_dynamic] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.47536 (%check)

which indicates that you need a BuildRequires: /usr/bin/nslookup or
BuildRequires: bind-utils.  Adding the former leads me to:
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/valid....FAILED test 9
        Failed 1/12 tests, 91.67% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/valid.t                 12    1   8.33%  9
Failed 1/1 test scripts, 0.00% okay. 1/12 subtests failed, 91.67% okay.
make: *** [test_dynamic] Error 255
error: Bad exit status from /var/tmp/rpm-tmp.17873 (%check)

at which point I'm out of ideas.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.