[Bug 189655] Review Request: mftrace - convert TeX bitmap fonts to TrueType fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mftrace - convert TeX bitmap fonts to TrueType fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189655





------- Additional Comments From tibbs at math.uh.edu  2006-04-23 15:24 EST -------
Odd, but I'm sure it will work itself out.  I'll review the current version.

Issues:
The empty %doc; you should probably package README.txt and ChangeLog.
Generally .pyo files are %ghost'ed instead of being packaged (see
http://fedoraproject.org/wiki/Packaging/Python), although now that RPM
byte-compiles everything in sight I'm wondering if the guidelines shouldn't be
changed.  In any case, I would suggest ghosting the .pyo files but if you don't
want to then I won't insist.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   89d5f70cdfad6ed7be146dd1b548cec1  mftrace-1.1.19.tar.gz
   89d5f70cdfad6ed7be146dd1b548cec1  mftrace-1.1.19.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock (development, i386).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; package has no test suite.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.