[Bug 189690] Review Request: swh-plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swh-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189690





------- Additional Comments From green at redhat.com  2006-04-24 07:19 EST -------
Thanks for looking at this.

(In reply to comment #2)
> * rpmlint gives the following, which are fairly self-explanatory to fix:
>   W: swh-plugins summary-ended-with-dot A set of audio plugins for LADSPA.
>   E: swh-plugins zero-length /usr/share/doc/swh-plugins-0.4.14/NEWS

Fixed.

> * The BuildRequirements for pkgconfig, gettext, libtool, bison, and
> perl-XML-Parser are unnecessary since Mock should pulls these in the minimum
> chroot. 

Ok, I've removed these.  But shouldn't the Exceptions section of the packaging
guidelines mention these packages as well?

> * Don't package the INSTALL doc, since it's the generic GNU Autotools file.

Right.

Updated bits here:

Spec URL: http://people.redhat.com/green/FE/FC5/swh-plugins.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/swh-plugins-0.4.14-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.