[Bug 171640] Review Request: perl-Log-Dispatch-FileRotate - Log to files that archive/rotate themselves

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 24 17:44:33 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Log-Dispatch-FileRotate - Log to files that archive/rotate themselves


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171640


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-04-24 13:44 EST -------
I have a few minutes free and this is a simple package, so:

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently
and follows the Perl specfile template.
* license field matches the actual license.
* license is open source-compatible. It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   b7cc69172d5c8b1a34c429d738bc3fa5  Log-Dispatch-FileRotate-1.14.tar.gz
   b7cc69172d5c8b1a34c429d738bc3fa5  Log-Dispatch-FileRotate-1.14.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
O %check is present but necessarily disabled.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list