[Bug 188430] Review Request: gtk+

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk+


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188430





------- Additional Comments From ville.skytta at iki.fi  2006-04-24 15:06 EST -------
Skimming diffs only so far, random findings or comments:

- The %if "%{?fedora}" > "4" conditionals can be dropped for a FC6+ only package
- %check belongs logically after %install, especially if you insist on keeping
  the "|| :" in it too to support old distro versions
- Does the test suite work in "headless" build environments?  What about mock?
- Rationale for 444 perms for /etc/gtk/gtkrc?  I believe 644 would do just fine
- Possibly unowned %{_datadir}/themes dir (I haven't checked the dep tree)
- specfile not UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.