[Bug 188359] Review Request: bugzilla - bug tracking tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





------- Additional Comments From tibbs at math.uh.edu  2006-04-26 19:23 EST -------
Paul: Yep, I know about -I; I just confused that message for something else.  I
guess I need to tighten the screws so that my brain won't fall out as often.

Ville: Thanks for sending your spec; I took a look at it and there are some
things that I personally like:

Your handling of python and ruby shebang lines is nice and more comprehensive
than trying to write patch files.

You filter out some dependencies that John's packages don't. (*.pl, DBD::*).  I
hadn't started looking into that yet but I it will need to be done.

To the package at hand:

It builds; rpmlint still complains about four .cvsignore files.  A quick find
will get rid of those.

rpmlint doesn't like not having any binaries in /usr/lib.  Does anyone have any
suggestions as to whether it's reasonable to keep the contrib stuff here?  If
not, where should it go?  Perhaps /usr/share since there's no arch-dependent
stuff there.

I like the current docs split, although after more thought I wonder how much of
that documentation is for the installer/configurer and how much is expected to
be web-accessible.  Will there be broken internal links if the -docs package
isn't installed?  And if the docs shouldn't be web-accessible, they should go
into /usr/share/doc.

Ville's package installs a crontab.  I don't know enough about bugzilla to know
if it really needs one, but if so then one should probably be installed with
everything commented out.  (An everything install shouldn't have crontabs and
such running by default.)

Ville's package restarts the web server.  Is it a good idea to do this here?

Ville's package has Requires for perl-Template-Toolkit, perl(Chart::Lines),
perl(GD) and Perl(PatchReader) which aren't in this package.   The
Template-Toolkit is found by RPM, and GD is a dependency so that's taken care
of.  Chart::Lines and PatchReader are in extras already so they should probably
be added as dependencies if Bugzilla will use them.

It looks like the Requires: filter didn't run at all; I still those things in
the final list.  I think you need to escape the parentheses when you call sed,
but you might also want to consider either emitting the script from the specfile
as Ville does, or do some substitution on the script in order to get the proper
value of %{__perl_requires} in there.  It's not guaranteed to live in
/usr/lib/rpm/perl_requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.