[Bug 190000] Review Request: partimage

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: partimage


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190000





------- Additional Comments From jkeating at redhat.com  2006-04-27 10:19 EST -------
Bad:
- Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Server requires should probably be %{name} = %{version}-%{release}
- Doesn't build on x86_64:

fs_xfs.h:115: error: conflicting declaration 'typedef long long int __int64_t'
/usr/include/bits/types.h:47: error: '__int64_t' has a previous declaration as
'typedef long int __int64_t'
fs_xfs.h:116: error: conflicting declaration 'typedef long long unsigned int
__uint64_t'
/usr/include/bits/types.h:48: error: '__uint64_t' has a previous declaration as
'typedef long unsigned int __uint64_t'
make[4]: *** [fs_xfs.o] Error 1

rpmlint isn't very happy w/ the 32bit package either.

W: partimage conffile-without-noreplace-flag /etc/pam.d/partimage
W: partimage conffile-without-noreplace-flag /etc/security/console.apps/partimage
E: partimage use-old-pam-stack /etc/pam.d/partimage
E: partimage use-old-pam-stack /etc/pam.d/partimage
W: partimage-server conffile-without-noreplace-flag /etc/logrotate.d/partimaged
W: partimage-server conffile-without-noreplace-flag /etc/pam.d/partimaged
W: partimage-server conffile-without-noreplace-flag /etc/rc.d/init.d/partimaged
E: partimage-server non-readable /etc/partimaged/partimagedusers 0600
E: partimage-server executable-marked-as-config-file /etc/rc.d/init.d/partimaged
E: partimage-server incoherent-logrotate-file /etc/logrotate.d/partimaged
W: partimage-server file-not-in-%lang /usr/share/man/en/man5/partimagedusers.5.gz
W: partimage-server file-not-in-%lang /usr/share/man/en/man8/partimaged.8.gz
W: partimage-server incoherent-subsys /etc/rc.d/init.d/partimaged $prog
W: partimage-server incoherent-init-script-name partimaged
E: partimage-server use-old-pam-stack /etc/pam.d/partimaged
E: partimage-server use-old-pam-stack /etc/pam.d/partimaged
E: partimage-server use-old-pam-stack /etc/pam.d/partimaged



Indifferent: 
- %description is a bit long winded...
- chmod of pam.d/partimaged followed by install -m seems redundant.


NEEDSWORK

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.