[Bug 190070] Review Request: par2cmdline

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: par2cmdline


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190070





------- Additional Comments From laurent.rineau__fc_extra at normalesup.org  2006-04-27 12:58 EST -------
Updated:
  Spec URL: http://www.di.ens.fr/~rineau/Fedora/par2cmdline.spec
  SRPM URL: http://www.di.ens.fr/~rineau/Fedora/par2cmdline-0.4-6.src.rpm

(In reply to comment #1)
> Issues:
> spectool cannot fetch the upstream source; your Source: URL is wrong.

Fixed, I think. I cannot reach dl.sourceforge.net at the present time. :-(

> you perhaps include a quick description of a PAR2 file in %description?

I modified it:
"par2cmdline is a program for creating and using PAR2 files. PAR2 files are
usually published in binary newsgroups, on Usenet. They apply the
data-recovery capability concepts of RAID-like systems to the posting and
recovery of multi-part archives. On Usenet, PAR2 files are posted together
with multi-part archives. par2cmdline can detect and repair dammaged files
using the corresponding PAR2 files."

Perhaps somebody can help me to correct my english. I declare the hunt of 
frenchisms opened! ;)

(I personnaly use it to repair files from binaries of Lost, season 2, which 
will not be on french TV until next year. But do not tell to anybody!)


> Please use the recommended BuildRoot:
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Done.

> Please remove Distribution: SuSE 9.1.

Sorry! Done. As you can see, I have adapted an existing (and trivial) spec 
file.

> I'm not sure about your Obsoletes: and Provides:, but I'll assume you 
> have some previous package history that requires this.  I'll ask the list
> for a bit of guidance.

I do not understand. parchive-1.1.4 exists in Fedora Extras 4. See
ftp://download.fedora.redhat.com/pub/fedora/linux/extras/4/SRPMS/parchive-1.1-4.src.rpm

par2cmdline provides the same functionalities as parchive, and has a 
symlink /usr/bin/par->par2. That's why I made this couple of 
Obsoletes:/Provides: Perhaps I am wrong. I must admit that I am not totally 
used with such a trick.

> rpmlint complains:
> You should remove the executable bits from these files in %build;

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.