[Bug 187964] Review Request: bsd-games - A collection of text-based games

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bsd-games - A collection of text-based games


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-04-28 04:34 EST -------
Looking good, almost there!

MUST:
-----
* rpmlint output is:
E: bsd-games configure-without-libdir-spec
E: bsd-games zero-length /var/games/robots_roll
E: bsd-games non-standard-executable-perm /usr/bin/canfield 02755
E: bsd-games non-standard-gid /var/games/phantasia/characs gamephant
E: bsd-games zero-length /var/games/phantasia/characs
E: bsd-games non-standard-executable-perm /usr/bin/snake 02755
E: bsd-games non-standard-gid /var/games/phantasia gamephant
E: bsd-games non-standard-dir-perm /var/games/phantasia 0775
E: bsd-games non-standard-gid /usr/bin/phantasia gamephant
E: bsd-games setgid-binary /usr/bin/phantasia gamephant 02755
E: bsd-games non-standard-executable-perm /usr/bin/phantasia 02755
E: bsd-games non-standard-executable-perm /usr/bin/robots 02755
E: bsd-games non-standard-gid /var/games/hack gamehack
E: bsd-games non-standard-dir-perm /var/games/hack 0775
E: bsd-games non-standard-gid /var/games/phantasia/motd gamephant
E: bsd-games zero-length /var/games/phantasia/motd
E: bsd-games non-standard-executable-perm /usr/bin/atc 02755
E: bsd-games zero-length /var/games/cfscores
E: bsd-games zero-length /var/games/atc_score
E: bsd-games non-standard-gid /var/games/hack/record gamehack
E: bsd-games zero-length /var/games/hack/record
E: bsd-games non-standard-executable-perm /usr/bin/battlestar 02755
E: bsd-games non-standard-gid /var/games/saillog gamesail
E: bsd-games zero-length /var/games/saillog
E: bsd-games non-standard-executable-perm /usr/bin/tetris-bsd 02755
E: bsd-games non-standard-gid /usr/bin/sail gamesail
E: bsd-games setgid-binary /usr/bin/sail gamesail 02755
E: bsd-games non-standard-executable-perm /usr/bin/sail 02755
E: bsd-games zero-length /var/games/tetris-bsd.scores
E: bsd-games non-standard-gid /var/games/phantasia/monsters gamephant
E: bsd-games non-standard-executable-perm /usr/bin/cribbage 02755
E: bsd-games zero-length /var/games/criblog
E: bsd-games non-standard-gid /var/games/phantasia/scoreboard gamephant
E: bsd-games zero-length /var/games/phantasia/scoreboard
E: bsd-games non-standard-gid /var/games/phantasia/mess gamephant
E: bsd-games zero-length /var/games/phantasia/mess
E: bsd-games non-standard-gid /var/games/hack/perm gamehack
E: bsd-games zero-length /var/games/hack/perm
E: bsd-games non-standard-gid /var/games/sail gamesail
E: bsd-games non-standard-dir-perm /var/games/sail 0775
E: bsd-games zero-length /var/games/battlestar.log
E: bsd-games non-standard-gid /var/games/phantasia/void gamephant
E: bsd-games zero-length /var/games/phantasia/void
E: bsd-games zero-length /var/games/snakerawscores
E: bsd-games non-standard-gid /var/games/phantasia/lastdead gamephant
E: bsd-games zero-length /var/games/phantasia/lastdead
E: bsd-games non-standard-gid /var/games/phantasia/gold gamephant
E: bsd-games zero-length /var/games/phantasia/gold
E: bsd-games zero-length /var/games/snake.log
E: bsd-games non-standard-gid /usr/bin/hack gamehack
E: bsd-games setgid-binary /usr/bin/hack gamehack 02755
E: bsd-games non-standard-executable-perm /usr/bin/hack 02755
These are all not a problem, see discussion above.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok (see below)
* No locales
* No shared libraries
* Not relocatable
* Package owns all dirs it installs, with one exception see below.
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no gui -> no .desktop file required


MUST Fix:
---------
* Add missing "Requires(Pre): /usr/sbin/groupadd"
* Package must own /usr/share/bsd-games


Should Fix:
-----------
* "# It looks like textutils became coreutils at some point.  I'm not sure
   # what is needed from it, so I'm commenting it out until I can find out.
   #Requires: textutils"
* Maybe use "BSD" as license, as all games eem to be under one or the other
  variant of the BSD license?
* Shouldn't the highscore files be marked %config(noreplace) ?
* Suspicious compiler warnings:
 "canfield/cfscores/cfscores.c:130: warning: comparison of unsigned expression <
0 is always false"
 "hunt/hunt/playit.c:117: warning: comparison is always true due to limited
range of data type"
 "hunt/hunt/playit.c:652: warning: comparison is always true due to limited
range of data type
 "phantasia/setup.c:71: warning: 'path' may be used uninitialized in this function"

 "

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.