[Bug 188369] Review Request: ctapi-cyberjack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctapi-cyberjack


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-04-30 16:57 EST -------
Sorry, no more time (today) for a full review. I did build it and ran it through
rpmlint:
W: ctapi-cyberjack strange-permission ctapi-cyberjack-2.0.8.tar.bz2 0744
W: ctapi-cyberjack strange-permission ctapi-cyberjack.spec 0600
You should fix these, easy.

E: ctapi-cyberjack library-not-linked-against-libc
/usr/lib64/libctapi-cyberjack.so.0
Hmm, bad error! Probably something wrong with the link command I can look into
this one for you if you want, just let me know.

W: ctapi-cyberjack devel-file-in-non-devel-package /usr/lib64/libctapi-cyberjack.so
That should be fixed, easy.

E: ctapi-cyberjack library-without-ldconfig-postin
/usr/lib64/libctapi-cyberjack.so.0
E: ctapi-cyberjack library-without-ldconfig-postun
/usr/lib64/libctapi-cyberjack.so.0
2 more which you should fix.

W: ctapi-cyberjack-devel no-documentation
No problem

E: ctapi-cyberjack-pcsc library-not-linked-against-libc /libcyberjack_ifd.so
Again probably the strange ld invocation, let me know if you need help

W: ctapi-cyberjack-pcsc conffile-without-noreplace-flag
/etc/reader.conf.d/cyberjack.conf
Amke tbis %config(noreplace)

W: ctapi-cyberjack-pcsc no-documentation
No problem

E: ctapi-cyberjack-pcsc executable-marked-as-config-file
/etc/reader.conf.d/cyberjack.conf
E: ctapi-cyberjack-pcsc script-without-shellbang /etc/reader.conf.d/cyberjack.conf
The second one is becayse of the first one, change the mode of this to 644.

I think a new version fixing this before the fullreview is a good idea, don't
hesitate if you need help with the not linked to libc errors, that should be
easy to fix for me.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.