[Bug 200941] Review Request: SooperLooper, a realtime software looping sampler (&Jack client)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SooperLooper, a realtime software looping sampler (&Jack client)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200941


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-08-02 01:48 EST -------
== Not an official review as I'm not yet sponsored ==
   Mock build for rawhide i386 is successfull with errors.
   Maybe you try adding autoconf in BR
   
* MUST Items:
      - dist tag is present.
      - rpmlint is silent
      - The package is named according to the Package Naming Guidelines.
      - The spec file name matching the base package sooperlooper, in the
format sooperlooper.spec.
      - This package meets the Packaging Guidelines.
      - The spec file for the package is legible.
      - The package is licensed with an open-source compatible license GPL.
      X This package dont have any License file.
      - The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (9b34c7cb8fc6daa4c7a9c17004680dac
 sooperlooper-1.0.8c.tar.gz)
    - This package successfully compiled and built into binary rpms for i386
architecture.
      - This package did not contain any ExcludeArch.
      - This package owns all directories that it creates. 
      - This package did not contain any duplicate files in the %files
listing.
      - This package  have a %clean section, which contains %{__rm} -rf
%{buildroot}.
      - This package used macros.
      - Document files are included.
      - Package did NOT contained any .la libtool archives.
      - Desktop file installed correclty.

Also,
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * I did not test package functionality

However i have question, when i saw build.log i found configure was called
nearly 5 times. What kind of this configuration script?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.