[Bug 199784] Review Request: psycopg2 - A PostgreSQL database adapter for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784





------- Additional Comments From devrim at commandprompt.com  2006-08-06 01:43 EST -------
Hello,

(In reply to comment #18)
> All previous blockers have been fixed.  Here's the new problems I've found:
> * %define ZPsycopgDAdir /var/lib/zope/Products/ZPsycopgDA/ hard codes /var.
>   Rather than do that you should use %{_localstatedir}.
> * You need to own the ZPsycoDAdir in the %files section.
> * Since you're listing the Zope *.pyo's separate from the other files, you
>   should ghost them just as you've ghosted the .pyo's in the main package:
>   %ghost %{ZPsycopgDAdir}/*.pyo
> * The Zope subpackage should Require: zope or %{_localstatedir}/lib/zope
> * Using cp -p instead of just cp when installing the zope subpackage will
>   preserve the file timestamps.

Thanks for the review. I fixed all.

New SPEC:
http://developer.postgresql.org/~devrim/rpms/other/psycopg2/python-psycopg2.spec

New SRPM:
http://developer.postgresql.org/~devrim/rpms/other/psycopg2/python-psycopg2-2.0.3-3.src.rpm

Regards, Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.