[Bug 201470] Review Request: genchemlab

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: genchemlab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201470





------- Additional Comments From jtorresh at gmail.com  2006-08-08 23:10 EST -------
Hi Paul,

* The .spec file you're linking to is not the same included in the .src.rpm.
Anyway, I'm reviewing the one from the source rpm.
* %{?smp_flags} should be %{?_smp_mflags}.
* It seems a common practice in Extras is to use "dl.sourceforge.net" as value
for the 'Source' tag instead of a mirror. This is not a blocker, though.

Everything else looks fine.
Fix the _smp_mflags typo and I'll approve this package.


REVIEW (genchemlab-1.0-3)

+ rpmlint shows no error.
+ package meets the naming guidelines.
+ spec-file is properly named.
X package doesn't meet the packaging guidelines
    - Parallel make macro should be %{?_smp_mflags} not %{?smp_flags} :)
+ package license is open-source compatible (GPL).
+ license field matches the actual license.
+ license file included in %doc.
+ spec file is written in english.
+ spec file is legible.
+ source files match upstream:
  ef364cff3f3e2dba4c62a5d1a0084bae  genchemlab-1.0.tgz
+ package successfully compiled, built and tested on i386 (rawhide).
+ all build dependencies are listed in BuildRequires.
+ package doesn't need to use %find_lang (no locales present).
+ package doesn't contain shared libraries.
+ package isn't relocatable.
+ package owns all directories that it creates.
+ no duplicate files in %files.
+ file permissions are properly set.
+ package has a %clean section containing rm -rf %{buildroot}.
+ package uses macros consistently.
+ package contains code, not content.
+ no -doc subpackage needed.
+ %docs don't affect application runtime.
+ package doesn't contain headers, static libraries or pkgconfig files (no devel
package).
+ GUI application; includes .desktop file installed correctly with
desktop-file-install.
+ package doesn't own directories owned by other packages.
+ package builds fine in mock (fedora-development-i386-core).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.