[Bug 201779] Review Request: xfsdump

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfsdump


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201779


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-08-09 09:08 EST -------
rpmlint is not silent
W: xfsdump summary-ended-with-dot Administrative utilities for the XFS filesystem.
Summary ends with a dot.

==> Remove dot at end of Summary description

E: xfsdump no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

==> you have not added Changelog. Add it.

W: xfsdump mixed-use-of-spaces-and-tabs
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

When i look at SPEC file i found :-
  - dist tag is missing
  - I dont think Obsoletes and Conflicts is needed as package name is not
changed from previous version.
   - You have added twice make %{?_smp_mflags}. Remove one line
   - No Document files added. try to add under %files
     %doc README doc/COPYING doc/CHANGES doc/README.xfsdump doc/xfsdump_ts.txt
   


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.