[Bug 201178] Review Request: pinball - Emilia Pinball game

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 9 21:50:35 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pinball - Emilia Pinball game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201178





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-08-09 17:41 EST -------
Okay. I'm happy with them.

The software works fine

Good
Licence fine
Includes update-icon-cache
No permission problems
No directory ownership problems
Has documentation (devel doesn't, can be ignored)
Software works and installs
No missing R's when installed
No missing BRs or Rs when compiling

Bad
Missing rm -rf %{buildroot} at the start of %install

Fix the one bad and it's good to go.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list