[Bug 201198] Review Request: alleggl - OpenGL support library for Allegro

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alleggl - OpenGL support library for Allegro


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201198





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-10 15:35 EST -------
(In reply to comment #6)
> 1. As it needs allegro >= 4.2.0, i suggest putting a version dependency on 
> allegro-devel for both the base and -devel packages
> 
I would rather not, tihs package is targeted soley at FC-5 and higher, so this
is not nescesarry. Versioned dependencies IMHO only give a false sense of
security, since often they are never updated after the initial specfile creation
even if upstreams requirements change.

> 2. As faq.txt contains information exclusively of interest to developing/
> building with alleggl I suggest moving it to -devel
> 
I was thinking along the same lines when creating the package, but I wasn't sure
since you agree I'll move it to devel.

> 3. readme.txt is primarily build instructions, I suggest excluding it.
> 
I was thinking along the same lines (again) when creating the package, but I
wasn't sure since you agree I'll remove it.

> 4. In -devel, the *.hhk *.hhc and *.hhp files are Microsoft Windows HTML Help 
> files if I remember right, probably of no interesting in Linux, I would
> exclude them.
Agreed, done.

Thanks for the review!, new version here:
Spec URL: http://people.atrpms.net/~hdegoede/alleggl.spec
SRPM URL: http://people.atrpms.net/~hdegoede/alleggl-0.4.0-0.4.rc4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.