[Bug 181445] Review Request: php-shout

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-shout


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445





------- Additional Comments From tibbs at math.uh.edu  2006-08-10 17:53 EST -------
I know this has sat around for too long, but the end is in sight.  The packaging
committee accepted the PHP guideline draft, although honestly it didn't say much
about extensions like this one.

In any case, I'm ready to move forward with this review.

The first problem is that it doesn't build; I had to add a BR: on pkgconfig. 
Previously you indicated that this wasn't required, but it certainly is a
problem.  Perhaps the new minimal buildroots have changed things since you were
able to build without the BR.

rpmlint finds this in SRPM:
W: php-shout macro-in-%changelog buildroot
  You just need to double a percent sign somewhere.

and in the built RPM:
E: php-shout script-without-shellbang /usr/share/doc/php-shout-0.3.1/TODO
E: php-shout script-without-shellbang /usr/share/doc/php-shout-0.3.1/README
  These are executable for some reason, and shouldn't be.

E: php-shout-debuginfo script-without-shellbang
/usr/src/debug/phpShout-0.3.1/php_shout.h
E: php-shout-debuginfo script-without-shellbang
/usr/src/debug/phpShout-0.3.1/php_shout.c
  These source files are executable, and should be chmodded in %prep.

The final set of macros which were chosen:
%global php_apiver  %((echo 0; php -i 2>/dev/null | sed -n 's/^PHP API => //p')
| tail -1)
%global php_extdir  %(php-config --extension-dir 2>/dev/null || echo "undefined")

Care to fix things up to use those?

Finally, I can't fetch the upstream source from the given URL. The only thing
that seems to be available is 0.3a.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.