[Bug 201481] Review Request: perl-DateTime-Format-MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-MySQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201481





------- Additional Comments From tibbs at math.uh.edu  2006-08-10 22:46 EST -------
Looks like all of the dependencies for this are in; this builds fine and rpmlint
has no complaints.

* source files match upstream:
   f52377ecdeb19055ae64037fb1ef530e  DateTime-Format-MySQL-0.04.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is not necessary)
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(DateTime::Format::MySQL) = 0.04
   perl-DateTime-Format-MySQL = 0.04-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(DateTime)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=46,  1 wallclock secs ( 0.27 cusr +  0.07 csys =  0.34 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.