[Bug 199920] Review Request: Palantir

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Palantir


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199920


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |j.w.r.degoede at hhs.nl
OtherBugsDependingO|163776                      |163778, 177841
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-11 00:52 EST -------
MUST:
=====
O rpmlint output is:
W: palantir hardcoded-packager-tag Tim
W: palantir redundant-prefix-tag
W: palantir setup-not-quiet
W: palantir mixed-use-of-spaces-and-tabs
These all must be fixed
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* "Compiles" and builds on FC-5 i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no .desktop file required

MUST fix
========
* rpmlint output:
W: palantir hardcoded-packager-tag Tim
Remove the packager tag
W: palantir redundant-prefix-tag
Remove the prefix tag
W: palantir setup-not-quiet
Add -q to %setup
W: palantir mixed-use-of-spaces-and-tabs
Only uses spaces for indenting, not tabs
* Add: "%defattr(-,root,root,-)" to the subpackages
  %files .
* Source0 must be a full URL

Questions:
==========
* I assume the java client doesn't build with gcj? Have you tried?
* Why is the building of the QT client optional and not done by default, since
  it is in a subpackage the user can always choose to not install it so I would 
  prefer to always build it and atleast build it by default.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.