[Bug 175047] Review Request: NetworkManager-openvpn

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NetworkManager-openvpn


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-11 01:02 EST -------
(In reply to comment #38)
> A new package is available at
>
http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/NetworkManager-openvpn-0.3.2-2.src.rpm
> (the spec is available at
>
http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/NetworkManager-openvpn.spec
> now). Cleaned up and incorporated most suggestions.
> 
> Upstream: It's from the 0.6 branch (0.6.4 tag) from CVS. The more recent
> versions are incompatible because the VPN DBUS API has changed.
> There are no tarballs, source is only available in CVS, thus no URL tag for now.
> 
> Four warnings remain:
> W: NetworkManager-openvpn no-url-tag
> explained above
> 

Okay, please add a comment above source0 with the bash commands which can be
used to recreate the tarbal (I know the tarbal might not be the same because
CVS has chanced, but thats ok).
> W: NetworkManager-openvpn conffile-without-noreplace-flag
> /etc/NetworkManager/VPN/nm-openvpn-service.name
> W: NetworkManager-openvpn conffile-without-noreplace-flag
> /etc/dbus-1/system.d/nm-openvpn-service.conf
> 
> These are directly relevant to a functioning service and should not be modified,
> thus I did not add noreplace (for if the files have to change during an
> upgrade). If it is policy to add noreplace anyway I can easily do this but from
> my understanding this is just error prone.
> 

OK

> W: NetworkManager-openvpn devel-file-in-non-devel-package
> /usr/lib/libnm-openvpn-properties.so
> 
> This is needed, it contains the GUI for configuring the VPN and is called from
> inside NM (to be more precise: nm-vpn-properties).
>

OK
 
> The find_lang has been removed for now. It should be used for i18n support but
> only threw errors so I commented it out.
> 

OK


TODO:
-Add an URL tag (see previous comments by others)
-Add comments to Source0 to explain how the tarbal was created
-Remove this as its probably no longer needed:
 "rm -f %{buildroot}%{_libdir}/lib*.a", if it is still needed then the
 --disable-static %configure argument isn't working and should be removed
-Remove these 2 lines:
 Requires(post): %{_bindir}/gtk-update-icon-cache
 Requires(postun): %{_bindir}/gtk-update-icon-cache
 These are not needed / unwanted, the scrip checks for existence of this
 file before using it and if its not there there is no reason to call it.

Once these are done (assuming you agree with the proposed changes) I'll approve
this and sponsor you. Feel free to create an account in the account system /
request FE membership if you alreadty have one, then I can approve and sponsor
in one go.



"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.