[Bug 201006] Review Request: HelixPlayer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HelixPlayer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201006


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |gauret at free.fr
                 CC|gauret at free.fr              |
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2006-08-11 16:18 EST -------
Needs work:
* The BuildRoot must be cleaned at the beginning of %install
* It doesn't look like the build uses the $RPM_OPT_FLAGS
* The spec files has a mixed use of spaces and tabs
* Directory /usr/lib/helix/ is unowned
* The desktop file should be installed with desktop-file-install and with the
vendor prefix set to "fedora" (wiki: PackagingGuidelines#desktop)
* Desktop file: the Categories tag should contain X-Fedora
  (wiki: PackagingGuidelines#desktop)
* The translation files are not properly tagged. Use the %find_lang macro
  (wiki: Packaging/ReviewGuidelines)
* Scriptlets: missing "gtk-update-icon-cache" in %post and postun, since you
install icons to %_datadir/icons/hicolor. (wiki: ScriptletSnippets)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.