[Bug 176253] Review Request: clement-2.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clement-2.1


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-12 01:38 EST -------
Almost there, why are these:
%attr(-,mail,mail) %{_usr}/bin/%{name}
%attr(-,mail,mail) %{_datadir}/%{name}-%{version}/

%attr(-,mail,mail) ?

Perhaps the binary is suid? In that case please reflect that in the %attr, even
if it already is made suid in %install. And I see no reason for the
%{_datadir}/%{name}-%{version} being mail.mail, prhaps this is a leftover from
when it contained the log files?


I also found some more should fixes, I see you use:
%{_usr}/bin in various places, you should replace that with %{_bindir}
also you use %{_usr}/lib, which will result in things getting installed under
/usr/lib instead of /usr/lib64 on 64 bit archs, is that intentional? If not
please replace it with %{_libdir}.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.