[Bug 199173] Review Request: clusterssh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clusterssh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199173


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-08-12 13:44 EST -------
Greetings. Here's a review:

OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
578208faf944100a233ae216fa230350  clusterssh-3.19.1.tar.gz
578208faf944100a233ae216fa230350  clusterssh-3.19.1.tar.gz.1
OK - Package compiles and builds on at least one arch.
n/a - Package needs ExcludeArch
OK - BuildRequires correct
n/a - Spec handles locales/find_lang
n/a - Spec has needed ldconfig in post and postun
n/a - Package is relocatable and has a reason to be.
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
n/a - -doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
n/a - Headers/static libs in -devel subpackage.
n/a - .pc files in -devel subpackage.
n/a - .so files in -devel subpackage.
n/a - -devel package Requires: %{name} = %{version}-%{release}
n/a - .la files are removed.
See below - Package is a GUI app and has a .desktop file
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
OK - Should build in mock. (fc6/i386)
OK - Should function as described.
OK - Should have sane scriptlets.

Issues:

1. The Source0 line doesn't work for me. I guess the osdl mirror
doesn't have a copy of this source.
http://easynews.dl.sourceforge.net/sourceforge/clusterssh/clusterssh-
3.19.1.tar.gz
worked ok for me.

2. You need to run desktop-file-install in %install for your .desktop
file. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

3. Might include the "THANKS" file as a %doc?

4. Why do you have the:
Requires:      perl-Tk perl-X11-Protocol
rpm picks up those requirements just fine without help. You should remove
those Requires unless there is some reason I don't see why they are there. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.