[Bug 182320] Review Request: gnome-build

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-build


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320





------- Additional Comments From jpmahowald at gmail.com  2006-08-13 23:28 EST -------
Given that -fPIC is being passed let's ignore shlib-with-non-pic-code.

A couple things yet to address:
Needs work:
- Fix the cp line in %install to a %doc macro or explain why it's needed.
- missing smp flags or a note on why not needed (was in 0.1.2-2 ?)

Recommend:
* Changing URL to http://www.gnome.org/projects/devtools/gnomebuild.shtml

Good:
+ license (GPL)
+ sources good
+ builds on devel x86_64
+ %find_lang macro
+ version-release good, is latest
+ macros used consistently
+ proper -devel subpackage
+ %clean good
+ ldconfig good
+ proper file ownership
+ proper permissions
+ removed .la files

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.