[Bug 187318] Review Request: mondo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mondo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187318





------- Additional Comments From dennis at ausil.us  2006-08-13 23:34 EST -------
ok quick thing drop the define addreq  and just put your requires in a 
Requires line  you do realise you dont have to have them all on one line?

do not hard code .fc5  in release use %{?dist} 

is there any reason you are not using %{?_smp_mflags} with make   you really 
should just call make not %{__make} 

drop --program-prefix=%{?_program_prefix} from %configure  your not using it 
at all 

you really should not add all the Requires  unless they  are only needed at 
run time.  if they please state so.
http://fedoraproject.org/wiki/Packaging/Guidelines#Requires

you dont need to require gcc  
http://fedoraproject.org/wiki/Extras/FullExceptionList

dont use %makeinstall  
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

I would write the spec file more like  attached spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.