[Bug 192311] Review Request: cobbler
bugzilla at redhat.com
bugzilla at redhat.com
Mon Aug 14 15:11:03 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: cobbler
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tibbs at math.uh.edu
------- Additional Comments From tibbs at math.uh.edu 2006-08-14 11:01 EST -------
The stalled review policy indicates that we give John one more week to respond
and then he can be unassigned from the package.
However, just a quick once over from me:
Source0: does not contain a URL to the upstream tarball. I'd consider this a
blocker unless somehow there is no upstream other than this package.
rpmlint on SRPM says:
W: cobbler strange-permission cobbler.spec 01664
Really odd for the sticky bit to be set on a spec file.
W: cobbler setup-not-quiet
Not a big deal; pass -q to the %setup macro if you want to quiet this.
rpmlint on the built RPM says:
E: cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/gui.py
0644
rpmlint fires this off anytime it sees a shebang line in a file that's not
executable. For Python source this is often bogus; it depends on whether the
code is actually runnable (i.e. contains something other than class
definitions). This seems to be the case here, so the rpmlint complaint can be
ignored.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list