[Bug 202521] Review Request: RutilT

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: RutilT


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202521





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-08-14 18:06 EST -------
ExclusiveArch:	i686 x86_64

You need a note explaining why it won't work elsewhere

BuildRequires:  gtk2-devel

You also need desktop-file-utils

sh configure.sh \
	--prefix=%{_prefix}

Not required

%configure --prefix=%{_prefix} (though the --prefix shouldn't be needed either)

%install

needs rm -rf $RPM_BUILD_ROOT at the start
is there no make install on the package?

%{_datadir}/rutilt/RutilT128x128.png
%{_datadir}/rutilt/RutilT16x16.png
...etc

Not needed

%{_datadir}/rutilt/

does the same job and you don't need all the pngs listed. It also gives the
package ownership of that directory

%{_datadir}/applications/livna-RutilT.desktop

Um? livna?

cat > %{name}.desktop <<EOF

No Version tag or try-exec (not sure if try-exec is strictly needed though)

install -m 0755 rutilt_helper $RPM_BUILD_ROOT%{_datadir}/rutilt/rutilt_helper
install -m 0755 set_ip.sh $RPM_BUILD_ROOT%{_datadir}/rutilt/set_ip.sh

These don't look like they're in the right place. Could you check them as I have
a feeling rutilt_help should be in %{_bindir} with set_ip possibly in /sbin

Plenty to be getting on with there...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.