[Bug 202423] Review Request: trackballs - Steer a marble ball through a labyrinth

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 14 23:32:07 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trackballs - Steer a marble ball through a labyrinth


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202423





------- Additional Comments From wart at kobold.org  2006-08-14 19:22 EST -------
This is a fairly easy package:

GOOD
====
* rpmlint output clean
* Package/spec name matches upstream
* GPL license ok, license file included
* Source matches upstream:
  9ea9ca93d87bb0f9ad8abca1b34af594  trackballs-1.1.2.tar.gz
* Builds in mock on FC5-i386, FC5-x86_64, FC6-i386, FC6-x86_64
* No need for a -devel subpackage
* No need for a -doc subpackage
* locale files installed correctly
* .desktop file installed correctly
* icon files installed and updated in %post/%postun correctly
* No duplicate %files
* Owns all directories that it creates; does not own directories that it
  should not.
* Runs on FC5-x86_64.

MUSTFIX
=======
* BR: libGL-devel is redundant.  This is already required by libGLU-devel.
* BR: gcc-c++ is already part of the minimal buildroot, so it can be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list