[Bug 202319] Review Request: perl-Data-Compare - Compare perl data structures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Data-Compare - Compare perl data structures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202319


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From cweyl at alumni.drew.edu  2006-08-14 22:30 EST -------
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ source files match upstream:
874a13f201c6948e84867f82d950907a  Data-Compare-0.13.tar.gz
874a13f201c6948e84867f82d950907a  Data-Compare-0.13.tar.gz.srpm
+ latest version is being packaged.
+ BuildRequires are proper.
 package builds in mock ( ).
+ rpmlint is silent.
+ final provides and requires are sane:
 == provides
 perl(Data::Compare) = 0.13
 perl(Data::Compare::Plugins::Scalar::Properties) = 1.0
 perl-Data-Compare = 0.13-1.fc5
 == requires
 perl(:MODULE_COMPAT_5.8.8)
 perl(Carp)
 perl(Data::Compare)
 perl(Exporter)
 perl(File::Find::Rule)
 perl(strict)
 perl(vars)
 perl(warnings)
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ All tests successful.
Files=7, Tests=76,  1 wallclock secs ( 0.55 cusr +  0.20 csys =  0.75 CPU)
%check is present and all tests pass:
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.