[Bug 176253] Review Request: clement-2.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clement-2.1


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |j.w.r.degoede at hhs.nl
OtherBugsDependingO|163776, 177841              |163779
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-15 05:25 EST -------
(In reply to comment #28)
> Version 2.1-192 SPECS file fine tuning, user/group clement used to run the main
> daemon
> 
> 
> Spec Url: ftp://ftp.safe.ca/pub/clement-2.1/SPECS/clement-2.1-192.spec
> SRPM Url: ftp://ftp.safe.ca/pub/clement-2.1/SRPMS/clement-2.1-192.src.rpm

Looks good, I've sponsored you and its ok to import this now. There is one small
thing you should fix before importing, please add " || :" at the end of all the
commands (not the if / endif lines) in the pre / post / postun scripts, that way
if one of these commands fail it doesn't cause the entire rpm transaction to fail.

This is especially important for the pre script, because of a user installs,
then removes and then tries to reinstall clement the groupadd and useradd will
fail because they already exist (which is ok, the exisiting user may be recycled
in this corner case).



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.