[Bug 202224] Review Request: libtirpc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtirpc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202224


steved at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(steved at redhat.com)|




------- Additional Comments From steved at redhat.com  2006-08-15 07:30 EST -------
> - Use %{name}-%{version} in URL field as to not have to update it every time the
>   version changes.
Done.

> - Remove Requires(postun) and (pre) on ldconfig, as %post -p picks that up
>   automagically
Done.

> - Replace %makeinstall with make install DESTDIR=%{buildroot}.  %makeinstall 
>   has been known to break packages in bad ways and its use is highly 
>   discouraged.
Done. This good to know... I thought %makeinstall was the approved way... I
guess I'll need to make this change other packages as well...

> - Don't package static libraries unless there is a VERY good reason to do so.
So we no longer support static libraries in devel packages? I don't think 
that is a very good idea.. Being that this is a relatively small library
and the RPC code is pretty legacy code... I really don't think excluding the
static library is a good idea...

> - Don't list gssapi requirement specifically, rpm will figure that out on its
>   own when building the package.
So your saying to removed the "Requires:  libgssapi" from the spec file?
How will rpm know that this library needes libgssapi? I must be missing
something... 

Spec file and RPM updated with first three requests... 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.