[Bug 202424] Review Request: trackballs-music - In-game music for Trackballs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trackballs-music - In-game music for Trackballs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202424


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-08-15 13:59 EST -------
GOOD
====
* rpmlint output, which can be safely ignored:
W: trackballs-music no-documentation
* Package/spec named appropriately
* Spec file legible and in Am. English
* Source matches upstream:
  5a8911006ca2be3b3571875ce34a5105  tb_design.ogg
  2d254de734c8d1c07ebd0c8d6fb893c0  tb_genesis.ogg
  ab033eac91054ed9700f6e0a8e2f1280  tb_hrluebke.ogg
  5a968fb86cc43fa08bbe323b63d0a457  tb_plinkeplanke.ogg
* Contains no code, but acceptable game content
* No need for -doc subpackage
* No need for -devel subpackage
* No need for a .desktop file
* Package does not need to own any directories
* File permissions ok
* Package works as expected when installed with the game

SHOULD
======
* You can prevent unneeded copying of the files by removing the 'cp'
  commands from %prep and using 'install -p -m 644 %{SOURCE0} %{SOURCE1} ...'
  in %install.

There's not too much to review here.  The confirmation of the GPL license from
the author is good enough for me.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.