[Bug 202439] Review Request: frozen-bubble - Frozen Bubble arcade gam

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frozen-bubble - Frozen Bubble arcade gam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202439


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-08-15 23:20 EST -------
GOOD
====
* rpmlint output clean
* Package and spec named appropriately
* Source matches upstream:
  2be5ead2aee72adc3fb643630a774b59  frozen-bubble-1.0.0.tar.bz2
* GPL license ok, license file included
* RPM_BUILD_ROOT cleaned where it ought to be
* .desktop file and icons installed correctly
* No duplicate %files
* Spec file legible and in Am. English
* Builds in mock on FC5-i386, FC5-x86_64, FC6-i386, FC6-x86_64
* No need for -doc subpackage
* No need for -devel subpackage
* No locales
* Owns all directories that it creates
* Does not own any directories that it should not
* Contains code and allowable game content
* File permissions look ok
* Not relocatable

MUSTFIX
=======
* BR: perl is not necessary.  It is already picked up by perl-SDL.

SHOULD
======
* There is some inconsistency in the use of $RPM_BUILD_ROOT vs.
  ${RPM_BUILD_ROOT}.  Both work.  Pick one and stick with it.

* The perl autoprovider in rpm adds some automatic provides since this package
  installs files into %{perl_vendorarch}.  If these files are only going
  to be used by frozen-bubble, wouldn't it be better to put them somewhere
  in %{_datadir}/frozen-bubble instead?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.