[Bug 198289] Review Request: python-pastescript - A pluggable command-line frontend

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 16 03:47:25 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pastescript - A pluggable command-line frontend


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198289


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com




------- Additional Comments From jpmahowald at gmail.com  2006-08-15 23:37 EST -------
rpmlint:

E: python-pastescript zero-length
/usr/lib/python2.4/site-packages/PasteScript-0.9-py2.4.egg-info/not-zip-safe
Ignore.

W: python-pastescript doc-file-dependency
/usr/share/doc/python-pastescript-0.9/docs/example_cgi_app.ini /usr/bin/env
W: python-pastescript doc-file-dependency
/usr/share/doc/python-pastescript-0.9/docs/example_wsgiutils_app.ini /usr/bin/env
Many python scripts require this, ignore.


About the name, upstream does use capitals when refering to Paste Script,
however Debian also does python-pastescript, I'm inclined to follow along.

* Uses both $RPM_BUILD_ROOT and %{buildroot}. Still readable but easily fixed on
next commit.

Good:
+ builds on devel x86_64
+ uses setuptools
+ license (MIT)
+ noarch
+ sources match upstream
+ sitelib macro
+ follows python templates for macros and file listing script
+ proper %clean
+ macro usage throughout
+ file permissions and ownership

Nearly ready for approval, but let's get resolution on the naming issue. See
also python-pastedeploy, bug #198288

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list