[Bug 174883] Review Request: distcc -- A free distributed C/C++ compiler system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: distcc -- A free distributed C/C++ compiler system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174883





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-08-16 18:13 EST -------
* Wed Aug 16 2006 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 2.18.3-1.8
- simplified LSB initscripts and support only one $DISTCC_OPTS variable
- ship sample sysconfig file for LSB
- use rpm macros to create the platform tuple instead of hardcoding
  'i386-redhat-linux'
- added '%%bcond_without fedora'


http://ensc.de/fedora/distcc/


=====

comment #8:
-----------

> But the file /etc/sysconfig/distccd is missing in your installation.

it will be read only, when existing. Hence, there is no real need to
ship it.

For documentation purposes, I added it in the current package


> I would furthermore suggest not to test for readability (-r) but for
> existance (-a)of the sysconf-file.

I do not see problems with '-r'



> E: distcc-server-lsb non-standard-gid /var/run/distccd distcc
> E: distcc-server-lsb non-standard-dir-perm /var/run/distccd 0775
> 
>   That should be fixed, I guess.

permissions/group are fine


comment #11:
------------

> %post gnome
> gtk-update-icon-cache -qf /usr/share/icons/hicolor 2>/dev/null || :
> 
> Please check
> 
> http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d

is ok; the 'touch ...' in the sample scriptlet might be from old FC
when 'gtk-update-icon-cache' did not know the '-f' flag.

I do not see sense in checking for existence first: the command will
be called with trailing '|| :' and potential error messages redirected
into /dev/null


> %pre server
> /usr/sbin/fedora-groupadd

package should have the corresponding 'Requires(pre): fedora-usermgmt'


>   for c in $name i386-redhat-linux-$name 
> 
> This is an "out of interest" question - why only i386-redhat?

thx; I compose the platform tuple from rpm macros now


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.