[Bug 202032] Review Request: efont-unicode-bdf: Unicode font by Electronic Font Open Laboratory

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efont-unicode-bdf: Unicode font by Electronic Font Open Laboratory


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202032





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-08-17 17:23 EST -------
Good

Builds cleanly in mock and installs fine.
rpmlint shows no problems
Directories are correctly owned
spec file is in american english
no ownership conflicts
Not showing up any duplicates
upstream corresponds with package md5sums
Same version
Correct use of scriptlets
Consistent use of macros

Bad

Should be

Requires: mkfontdir %{_sbindir}/chkfontpath

This is the only issue I can spot, so fix it and it should be good to go

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.