[Bug 202905] Review Request: perl-POE-Component-Server-HTTP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-Server-HTTP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202905


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-08-17 22:57 EST -------
Man, I have to say I really wish the Perl people would take their licensing a
bit more seriously.  This package says it's released under the same terms as
POE.  POE says it's released under the same terms as Perl.  Love the double
indirection.

Thanks for the great comment about the POE::API::Peek requirement.  The
remaining tests seem to run fine in mock and I'd expect them to be OK in the
buildsys.

* source files match upstream:
   d20963ebc65bebea4c863813861b9985  POE-Component-Server-HTTP-0.09.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::Server::HTTP) = 0.09
   perl(POE::Component::Server::HTTP::Connection)
   perl(POE::Component::Server::HTTP::Request)
   perl(POE::Component::Server::HTTP::Response)
   perl-POE-Component-Server-HTTP = 0.09-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(File::Spec)
   perl(HTTP::Date)
   perl(HTTP::Request)
   perl(HTTP::Response)
   perl(HTTP::Status)
   perl(POE)
   perl(POE::Component::Server::HTTP::Connection)
   perl(POE::Component::Server::HTTP::Request)
   perl(POE::Component::Server::HTTP::Response)
   perl(POE::Component::Server::TCP)
   perl(Socket)
   perl(Sys::Hostname)
   perl(bytes)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=26, 11 wallclock secs ( 0.45 cusr +  0.13 csys =  0.58 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.