[Bug 199681] Review Request: slab

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: slab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199681





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-22 09:25 EST -------
Ok it took a while b/c real life job took a to big toll on my time, but i've
finaly found some time to 'finish' this package.

Upstream (SuSe) had a new version (even though they still call it 0.6.2) which
intergrates a lot of fixes from SLED, but they also reformatted all the source
code and changed the library sources quite a bit, so i've had to re-base all the
patches by hand, which took a bit of time :-)

One of the 'major' bugs it fixes is that on startup 'Favorite Applications'
would only show 6 entries, even if more were defined; This seems to work
'correctly' now, and it will show all fav applications on startup now.

The new package can be found at:
http://develop.intermax.nl/slab/slab.spec
http://develop.intermax.nl/slab/slab-0.6.2-3.src.rpm

The re-based & re-worked patches are:
http://develop.intermax.nl/slab/gnome-main-menu-0.6.2-fedora.patch
http://develop.intermax.nl/slab/gnome-main-menu-0.6.2-disable-add-to-startup.patch

I've made the second one seperate, because i hope 'add to startup' actions will
be fixed soon(ish) by upstream, and this way it'll be easier to back out :-)

I've also changed the network button action from redhat-neat-control to
redhat-neat (aka system-config-network).

(In reply to comment #47)
The suspend button should show up if g-p-m reports it has this capability, else
the button is hidden

(In reply to comment #46)
I've changed slab (aka gnome-main-menu) to use the vendor supplied default main
menu icon, when using an fedora theme this will be the fedora logo, however
other themes can override this and put their own icon there.. In your case i
think tango inherits the default gnome iconset, and doesn't define the main menu
icon, so it uses the fall back one (from default gnome). If you changed tango to
inherit "bluecurve, gnome", then you should keep the fedora logo there

Do note that the package version now is: 0.6.2-3. This is *not* a mistake, the
previous packager choose 1.0 as a uneducated guess, the upstream version number
is 0.6.2, which is the tarbal this is based on. To fix this please run:
rpm -Uvh --oldpackage /location/to/rpms/slab-*.rpm

The 'cvsYYYYMMDD' tag was dropped since its now based on SuSe's gnome-main-menu
tarbal, and not a cvs checkout (which btw has the License: GPL tag, so this was
an available option)

I'd think this package is finally ready for review now :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.