[Bug 190029] Review Request: whysynth-dssi - DSSI software synthesizer plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029





------- Additional Comments From opensource at till.name  2006-08-23 08:55 EST -------
Here are some comments from me:

rpmlint shows some errors:

W: whysynth-dssi incoherent-version-in-changelog 0.1.3-3 20060122-3.fc5

last changelog entry mentions version 0.1.3-3 but the package is 20060122-3, 
the other entries may have the wrong version, too.

W: whysynth-dssi dangling-symlink /usr/bin/whysynth /usr/bin/jack-dssi-host

Don't know, what this means.

W: whysynth-dssi 
symlink-should-be-relative /usr/bin/whysynth /usr/bin/jack-dssi-host

Make sure, the symlink is relative.

W: whysynth-dssi macro-in-%changelog __rm
W: whysynth-dssi macro-in-%changelog makeinstall

Macros mentioned in %changelog must be escaped with an %, e.g. %%{__rm} 
instead of %{__rm}



Package builds in mock, but there are some warnigs in the build log:

whysynth_voice.c: In function 'y_voice_note_on':
whysynth_voice.c:79: warning: inlining failed in call to 'y_eg_setup': --param 
large-function-growth limit reached
whysynth_voice.c:214: warning: called from here
whysynth_voice.c:79: warning: inlining failed in call to 'y_eg_setup': --param 
large-function-growth limit reached
whysynth_voice.c:214: warning: called from here
whysynth_voice.c:79: warning: inlining failed in call to 'y_eg_setup': --param 
large-function-growth limit reached
whysynth_voice.c:214: warning: called from here
whysynth_voice.c:79: warning: inlining failed in call to 'y_eg_setup': --param 
large-function-growth limit reached
whysynth_voice.c:214: warning: called from here
[...]
whysynth_voice_render.c: In function 'y_voice_render':
whysynth_voice_render.c:1298: warning: inlining failed in call 
to 'oscillator': --param max-inline-insns-single limit reached
whysynth_voice_render.c:2171: warning: called from here
whysynth_voice_render.c:1298: warning: inlining failed in call 
to 'oscillator': --param max-inline-insns-single limit reached
whysynth_voice_render.c:2172: warning: called from here
whysynth_voice_render.c:1298: warning: inlining failed in call 
to 'oscillator': --param max-inline-insns-single limit reached
whysynth_voice_render.c:2173: warning: called from here
whysynth_voice_render.c:1298: warning: inlining failed in call 
to 'oscillator': --param max-inline-insns-single limit reached
whysynth_voice_render.c:2174: warning: called from here
whysynth_voice_render.c:283: warning: inlining failed in call 
to 'y_voice_update_lfo': --param large-function-growth limit reached
whysynth_voice_render.c:2352: warning: called from here
whysynth_voice_render.c:283: warning: inlining failed in call 
to 'y_voice_update_lfo': --param large-function-growth limit reached
whysynth_voice_render.c:2353: warning: called from here
whysynth_voice_render.c:283: warning: inlining failed in call 
to 'y_voice_update_lfo': --param large-function-growth limit reached
whysynth_voice_render.c:2354: warning: called from here
whysynth_voice_render.c:283: warning: inlining failed in call 
to 'y_voice_update_lfo': --param large-function-growth limit reached
whysynth_voice_render.c:2355: warning: called from here
whysynth_voice_render.c:283: warning: inlining failed in call 
to 'y_voice_update_lfo': --param large-function-growth limit reached
whysynth_voice_render.c:2356: warning: called from here



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.