[Bug 203249] Review Request: kpolynome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpolynome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-23 14:37 EST -------
Well, only for packaging issue.
mock build is okay.

* %post and %postun calls %{_bindir}/gtk-update-icon-cache.
  Require it as Requires(post) and Requires(postun).

* %patch0 -p0 -b .
  Very cosmetic, however, adding some suffix is perhaps
  preferable.

* chmod 644 %{_builddir}/%{name}-0.1/AUTHORS
  Why the explicit directory %{_builddir}/%{name}-0.1 necessary?
  Usually, in %build or %install stage, the working directory is
  what is written in %setup stage.

* Any reasons that document HTML files should be in 
  %{_docdir}/HTML/??/%{name} ? On my system, the only rpm which
  uses %{_docdir}/HTML/ is fedora-release-notes.

  Documents in other rpms should be in %{_docdir}/%{name}-%{version}.
  I suggest moving HTML document files.

* rpmlint is not silent.

E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/drawwidget.h
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/maindialog.h
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/drawwidget.cpp
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/maindlg.ui.h
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/matdata.cpp
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/curvedialog.h
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/main.cpp
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/curvedialog.cpp
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/matdata.h
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/maindialog.cpp
E: kpolynome-debuginfo script-without-shellbang
/usr/src/debug/kpolynome-0.1/src/curvedlg.ui.h

  --- permission issue. Fix this by changing the permissions of these files to 644.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.