[Bug 201502] Review Request: php-pear-PhpDocumentor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PhpDocumentor
Alias: phpDocumentor

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201502





------- Additional Comments From cweyl at alumni.drew.edu  2006-08-24 02:09 EST -------
The release tag is off by a little bit, the %{?dist} tag should always be at
the end of the tag unless it's a sub-release bump.

    0.2%{?dist}.%{rcrel} -> 0.2.%{rcrel}%{?dist}

According to Packaging/PHP, the package should also "Requires: php".

The latest version is 1.3.0 GA, but RC6 is being packaged.  To be fair, GA was
released the day after I assigned the review to myself, but... :)  Please
update the package to 1.3.0.

For the rpmlint warnings, the second is spurious and can be ignored.  The
first, however, could be fixed, but it appears part of the pear install
process is to check the md5sums of each file.  If the line ending can be fixed
w/o too much pain and mucking around with the pear-based install process, I'd
like to see it addressed.

You have php.ini both listed as source1, and created in %prep.  One or the
other works nicely, but both is redundant.  (Especially given nothing is ever
done with %{SOURCE0}...)

Also, while using php.ini to override the default memory and execution limits
works during the rpm build, the install fails on %post with the defaults on
the system:

 [root at zeus mock]# rpm -ivh php-pear-PhpDocumentor-1.3.0-0.2.fc5.RC6.noarch.rpm
 Preparing...                ########################################### [100%]
   1:php-pear-PhpDocumentor ########################################### [100%]
   PHP Fatal error:  Allowed memory size of 8388608 bytes exhausted (tried to
   allocate 229 bytes) in /usr/share/pear/PEAR/Installer.php on line 283
   Allowed memory size of 8388608 bytes exhausted (tried to allocate 72 bytes)

Installing the created php.ini as an additional .ini file in /etc/php.d
enables the install to suceed, e.g. in %install:

 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/php.d
 cp -p php.ini $RPM_BUILD_ROOT%{_sysconfdir}/php.d/phpDocumentor.ini

I don't get a good feeling from overriding core php.ini values in a package's
own modular ini file, but there doesn't seem to be another clean way to do
this.  (ideas/comments from those reading are solicited :) )  Perhaps it would
be a good idea to open a bug asking for the core memory limits be updated?
The response at least from the php maintainer would be valuable.

There's nearly a meg of tutorials and examples, which is great, but that's a
bit large to not be put in a -docs subpackage.

SO, to recap:
 * release tag
 * check on fixing rpmlint warning
 * update version
 * decide how php.ini is going to be included in srpm
 * deal with memory limits (a la a /etc/php.d/foo.ini file), open bug
 * split %_docdir/Documentation and %_docdir/tutorials off into a -docs
   package

X package meets naming and packaging guidelines. (release tag)
+ specfile is properly named, is cleanly written and uses macros consistently.
X dist tag is present (but in the wrong place)
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible (LGPL). License text included in package.
+ source files match upstream:
 e6f31c313b0b06c09acaf7047e6a5b23  PhpDocumentor-1.3.0RC6.tgz
 e6f31c313b0b06c09acaf7047e6a5b23  PhpDocumentor-1.3.0RC6.tgz.srpm
X latest version is being packaged.
+ BuildRequires are proper.
X package has required requires/provides statements.
+ package builds in mock (devel/x86_64).
O rpmlint is silent. (see below)
O final provides and requires are sane (except as noted above):
 ** phpdoc-1.3.0-0.2.fc5.RC6.noarch.rpm
 == rpmlint
 == provides
 phpdoc = 1.3.0-0.2.fc5.RC6
 == requires
 /usr/bin/php
 php-cli >= 5
 php-pear(PhpDocumentor) = 1.3.0
 ** php-pear-PhpDocumentor-1.3.0-0.2.fc5.RC6.noarch.rpm
 == rpmlint
 W: php-pear-PhpDocumentor wrong-file-end-of-line-encoding
 /usr/share/doc/php-pear-PhpDocumentor-1.3.0/Documentation/Release-old/Release-0.3.0
 W: php-pear-PhpDocumentor dangerous-command-in-%post install
 == provides
 php-pear(PhpDocumentor) = 1.3.0
 php-pear-PhpDocumentor = 1.3.0-0.2.fc5.RC6
 == requires
 /bin/sh
 /usr/bin/pear
 php-pear(PEAR) >= 1.4.9
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
O %check is not present; no automated test suite
+ sane scriptlets present.
+ code, not content.
X documentation is large (~876k), so -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.