[Bug 203249] Review Request: kpolynome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpolynome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-25 08:39 EST -------
rpmlint became clean. I think that this package is almost
okay.

Assigning to me.

Well:
* HTML documents
[tasaka1 at localhost SOURCES]$ rpm -ql kpolynome
/usr/bin/kpolynome
/usr/share/applications/fedora-kpolynome.desktop
/usr/share/apps/kpolynome
/usr/share/apps/kpolynome/kpolynomeui.rc
/usr/share/doc/kpolynome-0.1.2
/usr/share/doc/kpolynome-0.1.2/AUTHORS
/usr/share/doc/kpolynome-0.1.2/COPYING
/usr/share/doc/kpolynome-0.1.2/ChangeLog
/usr/share/doc/kpolynome-0.1.2/NEWS
/usr/share/doc/kpolynome-0.1.2/TODO
/usr/share/icons/hicolor/16x16/apps/kpolynome.png
/usr/share/icons/hicolor/32x32/apps/kpolynome.png

...... All HTML docs disappeared. I think you forgot to
add some entry to %doc.

* Changelog
%changelog
* Fri Aug 25 2006 Chitlesh Goorah 
- Fixed xcircuit.desktop

I think this is only a typo.

* chmod -x src/{drawwidget.*,maindi .....
Umm, well, it is okay, however,

$ find . -name \*.cpp -o -name \*.h | xargs chmod 0644
(pwd is $builddir/kpolynome-0.1.2)

in %prep stage is perhaps simpler.

* Requires:  kdelibs
is necessary? This package requires libkdecore.so.4 and this
correctly requires kdelibs.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.