[Bug 203864] Review Request: tripwire - IDS

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 26 05:48:01 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864





------- Additional Comments From fedora at theholbrooks.org  2006-08-26 01:48 EST -------
Spec URL: http://theholbrooks.org/RPMS/tripwire.spec
SRPM URL: http://theholbrooks.org/RPMS/tripwire-2.4.0.1-1.4.src.rpm

Thanks for the feedback all, I have updated all the external documentation to
reflect version 2.4, but not the internal text files (quickstart.txt) or man
pages.  I've submitted a bug to upstream asking them to correct the
documentation in the next release.  In the mean time, is it Fedora's (and thus
ours as the packagers) responsibility to fix silly things like forgetting to
bump version numbers in your documentation?  Obviously some quick command-line
perl will do the job nicely in %pre... what is everyone's feeling on the subject?

I have removed the %config flag from the cron script... I'm not entire sure why
it was there to begin with.  rpmlint output is now nonexistent :)

Also, I now echo the contents of README.RPM upon package install to let users
know about the next step required to initialize their tripwire database.

I also now include the COMMERCIAL file as a %doc (TRADEMARK was already there)

Kyrian, I would love to have you join this package as a co-maintainer once this
gets approved for FC5/6, especially as an x86_64 sanity check and another pair
of eyes at maintaining this rarely-updated code. Are there any other differences
between this approach and the RPM that you created?

rpmlint is a quick rpm 'sanity check' utility that scans through source as well
as binary RPM files for common mistakes and guideline violations. It is usually
the first tool run by package reviewers to make sure there isn't anything
majorly wrong with a submitted package before diving in and running checks
manually. You can 'yum update rpmlint' to get it, and then run it against any
RPM. The output is usually self-explanatory ('E'rrors and 'W'arnings), and SOME
output can be justified on a per-package basis, but no complaints from rpmlint
is usually desired.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list