[Bug 203774] Review Request: xcircuit - Electronic circuit schematic drawing program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcircuit - Electronic circuit schematic drawing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-26 08:27 EST -------
Fully checked. 

The remained things are:

>From http://fedoraproject.org/wiki/Packaging/Guidelines :

* Using %{buildroot} and %{optflags} vs 
  $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
  You use both %{_builddir} and $RPM_BUILD_ROOT . Choose one
  (although this is very cosmetic).

>From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
- All is okay.

Other packaging issues:
* %{__rm} %{_builddir}/%{name}-%{version}/examples/.xcircuitrc
  The explicit description of the directory 
  %{_builddir}/%{name}-%{version}/ is not necessary because the
  working directory is that directory.

* Well, you removed /usr/share/man/man1/xcircuit.1.gz and decided to
  install /usr/lib/xcircuit-3.4/man/xcircuit.1 , right? However,
  by doing this the simple use of "man xcircuit" no longer works,
  I have to explicitly point to the manual file
  "man /usr/lib/xcircuit-3.4/man/xcircuit.1", which is unpleasant to
  me. Could you explain why?

Other functional issues:
- All is okay. xcircuit surely works.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.