[Bug 202356] Review Request: terminus-font - Clean fixed width font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: terminus-font - Clean fixed width font


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356





------- Additional Comments From kevin at tummy.com  2006-08-27 14:37 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
fe9d8e25b9537f6b3154d07d3da50375  terminus-font-4.20.tar.gz
fe9d8e25b9537f6b3154d07d3da50375  terminus-font-4.20.tar.gz.1
OK - Package compiles and builds on at least one arch.
n/a - Package needs ExcludeArch
OK - BuildRequires correct
n/a - Spec handles locales/find_lang
n/a - Spec has needed ldconfig in post and postun
n/a - Package is relocatable and has a reason to be.
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
n/a - -doc subpackage needed/used.
OK - Packages %doc files don't affect runtime. 
n/a - Headers/static libs in -devel subpackage.
n/a - .pc files in -devel subpackage.
n/a - .so files in -devel subpackage.
n/a - -devel package Requires: %{name} = %{version}-%{release}
n/a - .la files are removed.
n/a - Package is a GUI app and has a .desktop file
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.

SHOULD Items:

See below - Should include License or ask upstream to include it.
OK - Should build in mock.
See below - Should have sane scriptlets.

Issues:

1. Should ping upstream to include a copy of the GPL COPYING file.

2. The Group doesn't seem right here. Other font packages use:
User Interface/X
(Granted that rpm groups aren't very usefull, but we should try and
be consistant at least).

3. perl and gawk are in the default BuildRequires, no need to list them.

4. rpmlint says:

W: terminus-font-x11 dangerous-command-in-%preun rm

Why remove those files?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.