[Bug 203964] Review Request: libburn - Library for reading, mastering and writing optical discs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libburn - Library for reading, mastering and writing optical discs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203964





------- Additional Comments From jwilson at redhat.com  2006-08-27 15:15 EST -------
(In reply to comment #3)
> So, this isn't actually a pre-release.  These peices of software have been
> released in the past, on other websites, which is why this is a svn snapshot on
> top of the old release, thus the 1.<snapshot> naming scheme.

Ah, okay. Now that I think about it, I do recall seeing some mention of a 0_2_1 tag in some merge 
script in the source, so that makes sense. Works for me.

> Docs added, tabs fixed, version requires fixed, and file perms changed.

Both Makefile and Makefile.am still have unnecessary execute permissions, but rpmlint doesn't seem to 
care, so good enough. Ah, and your changelog entry refers to cdrtools instead of cdrskin.

> I want
> to only use mainver where its needed, as it should go away soon when the release
> numbers sync up.  Then I only have to change it a few places.

Works for me, was only an idea, shouldn't have been under the "FIXME's". Really only needed it in the 
Requires: for cdrskin, looks good to me.

On with the formal review...

* package meets naming and packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently
* dist tag is present
* build root is correct
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* license field matches the actual license
* license is open source-compatible (GPL), license text included in package
* source files match upstream:
      n/a, svn snapshot
* latest version is being packaged
* BuildRequires are proper
* package builds in mock (rawhide x86_64)
* rpmlint only spits acceptable warnings (W: about lack of docs in some packages)
* final provides and requires are sane:
    cdrskin-0.1.4-2.20060823svn.fc6.x86_64.rpm
    cdrskin = 0.1.4-2.20060823svn.fc6
    =
    libburn = 0.2-2.20060823svn.fc6

    libburn-0.2-2.20060823svn.fc6.x86_64.rpm
    libburn.so.1()(64bit)  
    libburn = 0.2-2.20060823svn.fc6
    =
    /sbin/ldconfig  
    /sbin/ldconfig  
    libburn.so.1()(64bit)  

    libburn-devel-0.2-2.20060823svn.fc6.x86_64.rpm
    libburn-devel = 0.2-2.20060823svn.fc6
    =
    libburn = 0.2-2.20060823svn.fc6
    libburn.so.1()(64bit)  
    pkgconfig  

    libisofs-0.2-2.20060823svn.fc6.x86_64.rpm
    libisofs.so.1()(64bit)  
    libisofs = 0.2-2.20060823svn.fc6
    =
    /sbin/ldconfig  
    /sbin/ldconfig  
    libisofs.so.1()(64bit)  

    libisofs-devel-0.2-2.20060823svn.fc6.x86_64.rpm
    libisofs-devel = 0.2-2.20060823svn.fc6
    =
    libisofs = 0.2-2.20060823svn.fc6
    libisofs.so.1()(64bit)  
    pkgconfig  

* shared libraries are present, properly named (unversioned symlinks in -devel packages, versioned libs 
in the right places, with appropriate calls to ldconfig in scriptlets)
* package is not relocatable
* owns the directories it creates
* doesn't own any directories it shouldn't

* FIXME - no duplicates in %files
   libisofs-devel and libburn-devel both install the same include files, /usr/include/libburn/*

* file permissions are appropriate
* %clean is present
* %check is present and all tests pass:
        n/a, there is a 'make check' target, but it doesn't appear to do anything useful...
* scriptlets present -- proper ldconfig's
* code, not content
* documentation is small, so no -docs subpackage is necessary
* %docs are not necessary for the proper functioning of the package

* FIXME - headers properly in -devel packages, but currently duplicated

* pkgconfig files in -devel packages, properly Requires: pkgconfig
* no libtool .la droppings
* not a GUI app
* not a web app


Looks like the only thing to fix is the duplication of the libburn header files. I presume just drop them 
from libisofs-devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.