[Bug 191473] Review Request: kdiff3: Compare + merge 2 or 3 files or directories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdiff3: Compare + merge 2 or 3 files or directories


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191473





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-27 16:10 EST -------
(In reply to comment #37)
> Did I miss something?  I added the gtk-update-icon-cache as shown on the wiki 
> to %post and %postun.  Did you mean something else?
My bad, it looks like the adviced scriptlets have changed. Thus the package is
fine as is. Once I sponsor you I'll approve it and you can import it.

Please select a second package for me to review and to get an idea of how
familiar you are with FE's guidelines (this one went smotth, but had a bit of a
head start).

(In reply to comment #38)
> the gtk cruft is not needed for kde packages  
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28Packaging%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
> 
> states "For KDE, just 'touch'ing the top-level icon directory is enough."
> 
> there is no need to discusss this it is perfectly acceptable to not have the gtk
> stuff in kde packages. 
> 

For kdebase maybe, but for KDE packages which also are show in the gnome
applications menu it must still be there. since kdiff3 is shown in the gnome
applications menu, the update icon cache is needed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.